Re: [PATCH v11 09/12] cxl: Restore CXL HDM state after PCI reset

[Srirangan Madhavan]

On 9/4/26 2:23 AM, Richard Cheng wrote:
> > +static int cxl_restore_hdm(struct pci_dev *pdev)
> > +{
> In this function, after reset it will restore PCI state and HDM state,
> but I see no Device-DVSEC fields being restored.
>
> What if CONFIG_LOCK is not set, can we guarantee they remain the same?
>
> cxl_reset_enable_cache() only clears Control2 DisableCaching,
> I don't see it to restore Cache_enable or Mem_Enable , or Type-2 device
> driver is the one responsible for this ?
>
> Best regards,
> Richard Cheng.

In V12 I've added cache for the CXL Device DVSEC control state during 
early PCI discovery and restores the Cache Enable and Mem Enable bits 
after reset.
For decoder locks, a decoder that remains locked and committed after 
reset is left unchanged. If reset clears that state, in v12 I restore 
the cached decoder programming, recommit it, then reapply the
 cached lock bit.

--
Regards,
Srirangan