Re: [PATCH net-next 1/2] dt-bindings: net: econet: add EN751221 ethernet

[Caleb James DeLisle]

On 10/09/2026 01:09, Matheus Sampaio Queiroga wrote:
> Hello everyone, please excuse this email.
>
> In my opinion, the Ethernet driver for the Econet/Airoha MIPS SoCs 
> should be merged with the existing Airoha driver.
> i get PPE and xPON to start and work on the en7523, en751221, and en7528.


For my part, I don't agree with that opinion. When I first began 
developing this driver, I first began trying to work on that driver and 
I couldn't find a way that didn't lead to code which I consider ugly.

The main differences in hardware are the number of RX/TX chains in the 
QDMA, number of IRQ banks (we only have 1), QDMA register layout is very 
different and we have fewer features, and we have two GDMs rather than 
four. Also as I recall we have fewer channels available so QoS logic is 
not drop-in.

If someone proposed to me to add Airoha support to this driver, I 
wouldn't want the same econet_qdma.c file supporting both platforms, and 
in the Airoha driver the QDMA subsystem is more tightly coupled - so if 
I maintained that driver, I would not want them merged at all.

I added Lorenzo Bianconi the Airoha maintainer to this thread in case he 
may have some thoughts on the topic.


Thanks,

Caleb


> With a discussion on the Openwrt forum,
> it is said that integrating the en751627, en7528, and en7580 Ethernet 
> drivers into the new EcoNet Ethernet driver.
> These families are closer to what we already have in the Aiorha driver.