Re: [PATCH net-next] net: phy: air_en8811h: simplify en8811h_probe() trailing return

[Jakub Kicinski]

On Sun,  6 Sep 2026 20:35:57 +0100 Vitaliy Sochnev wrote:
> en8811h_clk_provider_setup() is now the last statement in the
> function, so the intermediate "if (ret) return ret; return 0;" is
> redundant.
> 
> Signed-off-by: Vitaliy Sochnev <sochnev.v.74@xxxxxxxxx>
> ---
>  drivers/net/phy/air_en8811h.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/net/phy/air_en8811h.c b/drivers/net/phy/air_en8811h.c
> index ec7c44ca68e7..99221ee87977 100644
> --- a/drivers/net/phy/air_en8811h.c
> +++ b/drivers/net/phy/air_en8811h.c
> @@ -1168,11 +1168,7 @@ static int en8811h_probe(struct phy_device *phydev)
>  
>  	priv->phydev = phydev;
>  	/* Co-Clock Output */
> -	ret = en8811h_clk_provider_setup(&phydev->mdio.dev, &priv->hw);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
> +	return en8811h_clk_provider_setup(&phydev->mdio.dev, &priv->hw);
>  }
>  
>  static int an8811hb_config_serdes_polarity(struct phy_device *phydev)

It's a personal preference, someone may think it's better to keep the
ret handling separate to avoid changing git blame when more code is
added. The shorter version is probably slightly better but not enough
to justify a cleanup of this sort IMO, sorry.