Re: [PATCH v2] riscv: dts: spacemit: k3: add i2s0-i2s5 nodes

[Troy Mitchell]

On Thu Sep 10, 2026 at 1:26 AM +08, sashiko-bot wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The newly added I2S device tree nodes use hardcoded magic numbers for DMA channels instead of the available hardware macros from `k3-pdma.h`.
> --
>
> commit 8163a94c4a6b08c0fea00752b0853d3f434a12d1
> Author: Troy Mitchell <troy.mitchell@xxxxxxxxxxxxxxxxxx>
>
> riscv: dts: spacemit: k3: add i2s0-i2s5 nodes
>
> Add the six SSPA-based I2S controller nodes for the K3 SoC.
> i2s0 and i2s2-i2s5 each have a dedicated per-controller sysclk
> divider, so they use the published 7-clock layout.
>
> Link: https://lore.kernel.org/all/20260721-kx-i2s-dts-v1-0-d22cb6cfaab5@xxxxxxxxxxxxxxxxxx/
>
>> diff --git a/arch/riscv/boot/dts/spacemit/k3.dtsi b/arch/riscv/boot/dts/spacemit/k3.dtsi
>> index c3f2dce0969c0..f2ff9f02249c3 100644
>> --- a/arch/riscv/boot/dts/spacemit/k3.dtsi
>> +++ b/arch/riscv/boot/dts/spacemit/k3.dtsi
>
> [ ... ]
>
>> @@ -1140,6 +1140,85 @@ uart10: serial@d401f000 {
>>  			status = "disabled";
>>  		};
>>  
>> +		i2s0: i2s@d4026000 {
>> +			compatible = "spacemit,k3-i2s";
>> +			reg = <0x0 0xd4026000 0x0 0x30>;
>> +			clocks = <&syscon_mpmu CLK_MPMU_I2S0_SYSCLK>,
>> +				 <&syscon_apbc CLK_APBC_I2S0_BCLK>,
>> +				 <&syscon_apbc CLK_APBC_I2S0_BUS>,
>> +				 <&syscon_apbc CLK_APBC_I2S0>,
>> +				 <&syscon_mpmu CLK_MPMU_I2S0_SYSCLK_DIV>,
>> +				 <&syscon_mpmu CLK_MPMU_I2S_SYSCLK>,
>> +				 <&syscon_mpmu CLK_MPMU_I2S_BCLK>;
>> +			clock-names = "sysclk", "bclk", "bus", "func",
>> +				      "sysclk_div", "c_sysclk", "c_bclk";
>> +			dmas = <&pdma 21>, <&pdma 22>;
>
> [Severity: Low]
> Could this use the available hardware macros from k3-pdma.h instead of
> hardcoded magic numbers, such as <&pdma K3_PDMA_SSPA0_TX>,
> <&pdma K3_PDMA_SSPA0_RX>?
Yes, will fix in the next version.


-- 
Troy Mitchell

Attachment: signature.asc
Description: PGP signature