Re: [PATCH v3 1/4] KVM: TDX: Track configurable CPUID bits allowed by KVM

[Binbin Wu]

On 9/10/2026 7:18 AM, Edgecombe, Rick P wrote:
> On Wed, 2026-09-09 at 15:29 -0700, Sean Christopherson wrote:
>> Eh, I'm with Xiaoyao.
> 
> I'm not sure what the disagreement is actually. No one is saying *never* TD
> first I think? Everyone agrees it is ideal to solve normal VMs before settling
> the TDX behavior.
> 
>>   Yeah, *ideally* we'd magically enable everything everywhere all at once.  In
>> reality, different VM types are going to support features at different times. 
>> More importantly, as Xiaoyao points out below in #1, unless we enable
>> everyting in a single patch, which is probably a terrible idea in most cases,
>> we'll still end up with staged/progressive enabling, i.e. we still need to
>> have patches that selectively enable and advertise a feature only for the VM
>> types that actually support the feature.
>>
>> This is all quite similar to Intel and AMD feature enabling being done at
>> different times.  The biggest difference is that Intel and AMD are mutually
>> exclusive and so KVM_GET_SUPPORTED_CPUID always reports the correct
>> information, but TDX already provides KVM_TDX_CAPABILITIES, so AFAICT we still
>> get accurate reporting for TDX, just in a slightly different way.
> 
> I think this actually surfaces another problem with TD-first enabling.
> KVM_TDX_CAPABILITIES only returns the directly configurable bits. Then recall,
> KVM_TDX_GET_CPUID returns the actual TDX module's view of CPUID bits to
> userspace. Then userspace calls KVM_SET_CPUID to actually put them on KVM's vcpu
> so they can match between Qemu, KVM and TDX

That brings up a point..

Today, vcpu->arch.cpu_caps[] is capped by kvm_cpu_caps[] (plus a few special
cases).  As mentioned in the cover letter, this patch series doesn't enforce
consistency between KVM's view and the guest's view of vCPU capabilities because
KVM doesn't currently use its own view to make decisions for TDs (e.g.
saving/restoring feature-related MSRs).

However, if KVM starts making decisions for TDX based on vcpu->arch.cpu_caps[],
intersecting userspace input with kvm_cpu_caps[] will not work for TDX.  I think
this is probably needed in the future?  If so, allowing features outside of
kvm_cpu_caps[] for TDX means we will need TDX-specific handling to construct
KVM's view of vCPU capabilities.  That likely implies tracking all
known/supported TDX features, which is doable, but it will make the allow list
bigger.
> 
> So if a bit is enabled for KVM_TDX_CAPABILITIES, but not yet in
> KVM_GET_SUPPORTED_CPUID. How should userspace interpret KVM_GET_SUPPORTED_CPUID?
> It can ignore it for TDX, but that is how it can find the PV bits today.
> 
> If we have a TD first feature, it could be a documentation update on how to
> interpret it. Or we could stuff the PV bits somewhere else for TDX and say to
> ignore KVM_GET_SUPPORTED_CPUID for TDX. I think we don't need to solve it before
> we begin filtering like this series has.
> 
>>
>>> I don't think "split lock detection" is a good example. We are discussing
>>> virtualizing a feature, or allowing a feature to be exposed to non-TDX and
>>> TDX guests. While "split lock detection" is not a virtualizable feature and
>>> how KVM handles it is all about how KVM fixes the architectural flaw of it.
>>
>> Yep.  If there are actual decisions to be made, versus simply adhering to the
>> architecture, then we'll need to incorporate the needs/abilities of flavors of
>> VMs KVM supports.  But for feature virtualization where right vs. wrong is
>> dictated by hardware specs, there really isn't anything we can do in KVM to
>> affect the guest-visible behavior (beyond things like performance
>> characteristics, but those aren't ABI in any case).
> 
> (Copying from my now aborted response).
> 
> I think it is not just the the behavior to the guest that matters. I agree guest
> behavior should normally be settled by the bare metal arch. But it is also how
> the TDX module decides to make the host side behave. And how it ends up fitting
> in to KVM for normal VMs. For "normal bits" it doesn't matter too much. But for
> anything with extra TDX arch decisions on top, ideally the TDX arch would not be
> finalized before the normal VM KVM design got to some level of maturity.
> 
> In any case, I don't see any big disagreement between anyone actually. If anyone
> has any big worry please make it clear.