Re: [PATCH] KVM: arm64: Fix kvm_get_vtcr() kernel-doc
From: Karl Mehltretter
Date: Wed Sep 09 2026 - 22:59:37 EST
On Wed, Sep 09, 2026 at 08:36:40AM +0100, Fuad Tabba wrote:
> Hi Karl,
> While you're on that line, the description is also inaccurate, so you
> could fix both in one go and save a follow-up touching the same line:
>
> > - * @phys_shfit: Value to set in VTCR_EL2.T0SZ.
> > + * @phys_shift: Value to set in VTCR_EL2.T0SZ.
>
> kvm_get_vtcr() sets T0SZ to 64 - phys_shift, so phys_shift isn't the
> value written to the field, it's the IPA size in bits. Something like:
>
> * @phys_shift: IPA size, in bits.
>
Hi Fuad.
well spotted. A typo seldom comes alone :)
I'll fix that.
Thanks,
Karl