Re: [PATCH v2 0/2] i3c: dw: Document optional core reset and drop redundant name

[Jisheng Zhang]

On Mon, Jul 20, 2026 at 01:05:08PM +0530, Shubham Patil wrote:
> This series documents the optional core reset for the Synopsys
> DesignWare I3C master and updates the driver to match the binding.
> The DesignWare I3C master IP has a single core reset input. The
> binding never documented this reset, and the driver looked it up by
> the "core_rst" name even though a name is redundant for a single
> reset line.

Hi DT maintainers,

AIUI, the dw i3c explicitly says there are three reset signals in
total:
core_rstn, for core
presetn, for apb
dmareset, for dma

and I'm adding apb reset suppport, given this series has been applied,
we have three choices:

1.revert patch2 and document the "core_rst" reset dt-binding. This
equals to v1 of this series.

2.add a patch to add the "core_rst" reset, but allow no reset name

3.add a patch to add the "core" reset, but allow no reset name

Which one do you prefer?

Thanks

> 
> This series addresses both:
>   - Patch 1 documents the optional 'resets' property in the binding.
>     The reset is kept optional because the reset line is
>     integration-specific.
>   - Patch 2 removes the "core_rst" reset name from the driver and
>     looks the reset up by passing NULL, since the name is redundant
>     for a single reset.
> 
> Changes in v2:
> - Updated commit description for binding patch
> - Dropped reset-names from the binding
> - Added driver patch to remove redundant reset name
> 
> Note:
> The DesignWare I3C driver support was added by
> commit 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP").
> 
> The original Synopsys DesignWare I3C binding was added by
> commit 116e246a8bcd ("dt-binding: i3c: Document Synopsys DesignWare I3C"),
> but it did not document the optional core reset.
> ---
> Shubham Patil (2):
>   dt-bindings: i3c: dw: Document missing optional core reset
>   i3c: master: dw: Drop redundant core reset name
> 
>  Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 3 +++
>  drivers/i3c/master/dw-i3c-master.c                            | 2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> 
> base-commit: a13c140cc289c0b7b3770bce5b3ad42ab35074aa
> -- 
> 2.34.1
> 
> 
> -- 
> linux-i3c mailing list
> linux-i3c@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-i3c