Re: [PATCH v7 04/10] mfd: nct6694: Rename driver to nct6694-usb and update Kconfig

[Ming Yu]

Hi Lee,

Thank you for reviewing.

Lee Jones <lee@xxxxxxxxxx> 於 2026年9月3日週四 下午6:24寫道：
>
> On Fri, 21 Aug 2026, a0282524688@xxxxxxxxx wrote:
>
> > From: Ming Yu <a0282524688@xxxxxxxxx>
> >
> > Rename nct6694.c to nct6694-usb.c to accurately reflect that it
> > implements the USB transport backend.
> >
> > Additionally, introduce a new MFD_NCT6694_USB Kconfig option and convert
> > the existing MFD_NCT6694 into a hidden core symbol. The core symbol is
> > now automatically selected by the transport drivers.
> >
> > This Kconfig and naming restructure aligns with standard MFD transport
> > abstraction practices, paving the way for future interfaces (e.g., HIF)
> > to be seamlessly integrated.
> >
> > Signed-off-by: Ming Yu <a0282524688@xxxxxxxxx>
> > ---
> > Changes in v7:
>
> No changes or you forgot to populate it?
>

There is no functional change in v7 for this patch; I'll mark it
explicitly as "No changes." in v8.

> > Changes in v6:
>
...
> > --- "a/drivers/mfd/Kconfig"
> > +++ "b/drivers/mfd/Kconfig"
> > @@ -1164,19 +1164,30 @@ config MFD_MENF21BMC
> >         will be called menf21bmc.
> >
> >  config MFD_NCT6694
>
> So what does this do now?
>
> Will there be another core symbol soon?
>

MFD_NCT6694 is now a hidden symbol that builds only the
transport-agnostic core (nct6694-core.o, added in 5/10): the IRQ
domain, IDA pools and MFD sub-device registration shared by every
backend. It has no prompt because it is not useful on its own, so it
is  selected automatically by whichever transport driver is enabled.

There won't be a second core symbol. The next addition is another
*transport*, MFD_NCT6694_HIF (eSPI, 10/10), which likewise selects
MFD_NCT6694. So the final shape is a single shared core selected by
one  or more transports:
    MFD_NCT6694 (hidden core)                 -> nct6694-core.o
        ^ select
    MFD_NCT6694_USB (USB transport)    -> nct6694-usb.o
    MFD_NCT6694_HIF (eSPI transport)     -> nct6694-hif.o   [10/10]

I'll clarify this in the commit message for v8.

> > -     tristate "Nuvoton NCT6694 support"
> > +     tristate
> >       select MFD_CORE
> > +     help
> > +       Core MFD support for the Nuvoton NCT6694 peripheral expander.
> > +       This provides the common APIs and shared structures used by all
> > +       interfaces (USB, HIF) to access the NCT6694 hardware features
> > +       such as GPIO, I2C, CAN-FD, Watchdog, ADC, PWM, and RTC.
> > +
...
>
> --
> Lee Jones

Thanks,
Ming