Re: [PATCH v5 05/10] iio: dac: mcp47feb02: Avoid unjustified probe failure on missing label

[Andy Shevchenko]

On Wed, Sep 09, 2026 at 05:18:48PM +0300, Ariana Lazar wrote:
> Fix unjustified probe failure on missing optional 'label' property by
> replacing dev_err_probe() with dev_err(). Correct %pfw usage by passing the
> child fwnode handle directly in the error message.

...

>  		ret = fwnode_property_read_string(child, "label", &data->labels[reg]);
>  		if (ret)
> -			return dev_err_probe(dev, ret, "%pfw: invalid label\n",
> -					     fwnode_get_name(child));
> +			dev_err(dev, "%pfw: invalid label\n", child);

Why not leaving dev_err_probe()? And why error in such a case? Perhaps you want
dev_warn_probe()?

-- 
With Best Regards,
Andy Shevchenko