Re: [PATCH v2] drm/gud: Ignore damage clips in full update mode

[Thomas Zimmermann]

Am 10.09.26 um 03:49 schrieb Sophie D:
> When running in full update mode, previously small updates (such as
> moving the mouse across the screen) would cause many full frames to be
> generated. This would bog down the bus and lower the effective framerate
> significantly - I was seeing a drop from 60 FPS to 2 FPS.
>
> Set ignore_damage_clips in full update mode so the damage iterator
> yields a single full-plane rectangle instead of one per clip.
>
> Fixes: 73cfd166e045 ("drm/gud: Replace simple display pipe with DRM atomic helpers")
> Cc: <stable@xxxxxxxxxxxxxxx> # 6.18.x
> Signed-off-by: Sophie D <patches@xxxxxxxxx>

Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

Thanks for the fix.

> ---
> v2: set ignore_damage_clips in atomic_check instead of merging clips in
>      atomic_update (Thomas Zimmermann)
>
>   drivers/gpu/drm/gud/gud_pipe.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/gud/gud_pipe.c b/drivers/gpu/drm/gud/gud_pipe.c
> index 5ef887d84..3388fdc8e 100644
> --- a/drivers/gpu/drm/gud/gud_pipe.c
> +++ b/drivers/gpu/drm/gud/gud_pipe.c
> @@ -482,6 +482,9 @@ int gud_plane_atomic_check(struct drm_plane *plane,
>   	if (!new_plane_state->visible)
>   		return 0;
>   
> +	if (gdrm->flags & GUD_DISPLAY_FLAG_FULL_UPDATE)
> +		new_plane_state->ignore_damage_clips = true;
> +
>   	if (old_plane_state->rotation != new_plane_state->rotation)
>   		crtc_state->mode_changed = true;
>   

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)