Re: [PATCH v7] i2c: xiic: restore non-managed runtime PM to fix clk WARN flood
From: Andy Shevchenko
Date: Thu Sep 10 2026 - 02:49:21 EST
On Wed, Sep 09, 2026 at 08:51:33PM -0700, Abdurrahman Hussain wrote:
> On Fri Aug 21, 2026 at 6:12 PM PDT, Abdurrahman Hussain wrote:
> Gentle ping on this one. It has been quiet since v7 went out on Aug 21.
>
> Andy, v4 onwards switched to request_threaded_irq()/free_irq() with the
> explicit free in the probe error path and in remove(), per your comment on
> v3. Does that address your concern, or is there anything else you would
> like changed?
Seems okay to me.
> Andi, this is a regression fix for 50c63491ff26 (the devres conversion),
> and the WARN fires on every unbind/rmmod of the driver, so it would be
> good to get it into 7.2 or early 7.3 fixes if the patch looks OK to you.
v7.2 is already released, so v7.3-rcX is the best you can get.
> Happy to respin if anything is still open.
--
With Best Regards,
Andy Shevchenko