Re: [PATCH] firmware: QCOM interfaces should depend on ARCH_QCOM

[Sumit Garg]

On Thu, Aug 6, 2026 at 4:05 PM Geert Uytterhoeven
<geert+renesas@xxxxxxxxx> wrote:
>
> The various Qualcomm firmware interfaces are only present on Qualcomm
> systems.  Hence add dependencies on ARCH_QCOM, to prevent asking the
> user about them when configuring a kernel without Qualcomm SoC support.
> Make QCOM_PAS invisible instead, as it is already selected by its users
> when needed.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> I wondered whether QCOM_SCM should be made invisible, too, as it seems
> to be selected by its users? But apparently commit 5c1a2975d23c51c0
> ("firmware: qcom_scm: Migrate to generic PAS service") in net-next/main
> and soc/for-next made it visible on purpose?
> ---
>  drivers/firmware/qcom/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>

Reviewed-by: Sumit Garg <sumit.garg@xxxxxxxxxxxxxxxx>

-Sumit

> diff --git a/drivers/firmware/qcom/Kconfig b/drivers/firmware/qcom/Kconfig
> index c7f8413ab996cf12..691db0ded8e8cf63 100644
> --- a/drivers/firmware/qcom/Kconfig
> +++ b/drivers/firmware/qcom/Kconfig
> @@ -7,7 +7,7 @@
>  menu "Qualcomm firmware drivers"
>
>  config QCOM_PAS
> -       tristate "Qualcomm generic PAS interface driver"
> +       tristate "Qualcomm generic PAS interface driver" if COMPILE_TEST
>         help
>           Enable the generic Peripheral Authentication Service (PAS) provided
>           by the firmware. It acts as the common layer with different TZ
> @@ -16,6 +16,7 @@ config QCOM_PAS
>
>  config QCOM_PAS_TEE
>         tristate "Qualcomm PAS TEE interface driver"
> +       depends on ARCH_QCOM || COMPILE_TEST
>         select QCOM_PAS
>         depends on TEE
>         depends on !CPU_BIG_ENDIAN
> @@ -26,6 +27,7 @@ config QCOM_PAS_TEE
>
>  config QCOM_SCM
>         tristate "Qualcomm PAS SCM interface driver"
> +       depends on ARCH_QCOM || COMPILE_TEST
>         select QCOM_PAS
>         select QCOM_TZMEM
>         default y if ARCH_QCOM
> --
> 2.43.0
>