Re: [PATCH v7 1/3] mm: make persistent huge zero folio read-only

[David Hildenbrand (Arm)]

On 9/10/26 09:24, Mike Rapoport wrote:
> On Thu, Sep 10, 2026 at 02:22:25PM +0800, Xueyuan Chen wrote:
>> On Wed, Sep 9, 2026 at 11:18 PM David Hildenbrand (Arm)
>> <david@xxxxxxxxxx> wrote:
>>>
>>>
>>> I think getting something consistent for now is the most important thing. :)
>>>
>> Hi David,
>>
>> OK, I'll move the highmem check into set_direct_map_ro().
> 
> Consistent means leaving highmem check in the caller ...
>  
>> Should I also update the x86 set_direct_map_invalid_noflush() and
>> set_direct_map_default_noflush() helpers in this series to skip
>> highmem pages?
> 
> ... or checking it in all set_direct_map functions.
> 
> I'd keep the check in huge_zero_init() in this patchset.

Agreed!

-- 
Cheers,

David