Re: [PATCH net] octeontx2-pf: Fix autoneg reporting in ethtool

[Paolo Abeni]

On 9/3/26 6:11 PM, nshettyj@xxxxxxxxxxx wrote:
> From: Hariprasad Kelam <hkelam@xxxxxxxxxxx>
> 
> The driver adds the supported autoneg bit before copying the supported
> link modes. The copy clears the bit, so ethtool does not report
> supported autoneg correctly.
> 
> Add the supported autoneg bit after copying the supported link modes.
> Also add the advertised autoneg bit when firmware reports it.
> 
> Fixes: 1a50280c25ec ("octeontx2-pf: ethtool physical link status")
> Signed-off-by: Nitin Shetty J <nshettyj@xxxxxxxxxxx>
> Signed-off-by: Hariprasad Kelam <hkelam@xxxxxxxxxxx>
The SoB chain looks wrong, likely Hariprasad' SoB should come first.

Please have a look at commit c82ff94592fb68f529afe63ca7f5ddb7dae4ba83:
you are expected to reply to the LLM comments.

FTR lacking the H/W specific knowledge on your NIC, all the comments
looked valid to me, I'm setting your patches to changes requested.

/P