Re: [PATCH v2 1/2] dt-bindings: clock: qcom: Add Hawi CAMCC compatible strings

[Krzysztof Kozlowski]

On Tue, Sep 08, 2026 at 11:01:22PM -0700, Vivek Aknurwar wrote:
> The Hawi SoC is a derivative of Kaanapali  with an updated camera
> clock controller (CAMCC). While the overall block structure is
> similar, Hawi's CAMCC differs from Kaanapali in the following ways:
> 
>   - Uses Taycan EHA-T PLLs instead of Taycan EKO-T PLLs, with an
>     additional ninth PLL (PLL8)
>   - Adds a SQPF block with its own GDSC, AHB clock, and BCR reset
>   - Adds a CX GDSC (CAM_CC_TITAN_TOP_CX_GDSC) for the camera subsystem
>   - Expands ICP from one to two instances (ICP_0 and ICP_1)
> 
> Due to these differences, Hawi requires its own 'qcom,hawi-camcc'
> compatible string and a dedicated driver.
> 
> The BIST MCLK clock controller (CAMBISTMCLKCC) is unchanged between
> Hawi and Kaanapali, allowing the existing Kaanapali CAMBISTMCLKCC
> driver to support both SoCs without modification.
> 
> Add the 'qcom,hawi-camcc' and 'qcom,hawi-cambistmclkcc' compatible
> strings to the binding, along with the corresponding clock ID header.
> 
> Signed-off-by: Vivek Aknurwar <vivek.aknurwar@xxxxxxxxxxxxxxxx>
> ---
>  .../bindings/clock/qcom,sm8450-camcc.yaml          |  27 ++--
>  include/dt-bindings/clock/qcom,hawi-camcc.h        | 165 +++++++++++++++++++++
>  2 files changed, 182 insertions(+), 10 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof