RE: [PATCH rtw-next v3 2/3] wifi: rtw88: usb: only let the frames a dozing station needs use the after-DTIM queue

[Ping-Ke Shih]

Mehmet Fide <mehmet.fide@xxxxxxxxx> wrote:
> From: Mehmet Fide <mehmet.fide@xxxxxxxxxxxxxxxxxx>
> 
> With the budget in place the high queue can no longer take the chip
> down, but ordinary chatter still competes with the frames a sleeping
> station actually needs. mac80211 marks every broadcast and multicast
> frame with IEEE80211_TX_CTL_SEND_AFTER_DTIM while a station dozes,
> mDNS and SSDP included, so under normal traffic the budget is spent on
> frames nobody waits for.
> 
> Do what the vendor driver does with its default "allow special" high
> queue filter: admit only ARP, EAPOL and DHCP to the after-DTIM path,
> the frames a station coming out of power save has to see; everything
> else goes out on its access category queue at line rate. The frames
> are classified the way rtw89_core_tx_btc_spec_pkt_notify() does it,
> from skb->protocol and the network and transport header offsets that
> mac80211 keeps from the netdev path; EAPOL is the control port flag.
> Frames the AP relays between its own stations arrive as ETH_P_802_3
> and are not inspected, they leave on the access category queue.
> 
> With the filter in place the page pool stays at 1803 through the same
> 180 second storm, a DHCP flood still takes the after-DTIM path (and is
> then held by the budget), and join/ping cycling without power save is
> unchanged (10/10).
> 
> Signed-off-by: Mehmet Fide <mehmet.fide@xxxxxxxxxxxxxxxxxx>

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>