Re: [PATCH 1/2] drm/verisilicon: set blend mode for the primary plane

[Thomas Zimmermann]

Hi

Am 10.09.26 um 11:02 schrieb Icenowy Zheng:
[...]
> As the DC8000 support is being developed (a new revision of that
> patchset just appeared on this Tuesday), and on that hardware the A
> channel has no meaning except for being ignored (no blend configuration
> register for the primary plane), maybe I still need to remove alpha
> formats (at least for DC8000)?
>
> Although in such case, when the overlay support is going to be
> introduced, two format tables need to be present -- one with alpha and
> one without.

Sure. In my opinion, there should be a dedicated format table for each 
type of plane. These "super tables" that sometimes try to catch all 
cases in a single place are not great.

Best regards
Thomas

> Thanks,
> Icenowy
>
> > Best regards
> > Thomas
> >
> >
> > > Thanks,
> > > Icenowy
> > >
> > > > In pl111, we now remove the ARGB foramts because the hardware
> > > > does
> > > > not
> > > > handle them at all. The situation seems less clear in
> > > > verisilicon.
> > > >
> > > > Best regards
> > > > Thomas
> > > >
> > > >
> > > > > Thanks,
> > > > > Icenowy
> > > > >
> > > > > > Best regards
> > > > > > Thomas
> > > > > >
> > > > > > > Thanks,
> > > > > > > Icenowy
> > > > > > >
> > > > > > > > Signed-off-by: Icenowy Zheng <zhengxingda@xxxxxxxxxxx>
> > > > > > > > ---
> > > > > > > >      drivers/gpu/drm/verisilicon/vs_primary_plane.c | 3
> > > > > > > > +++
> > > > > > > >      1 file changed, 3 insertions(+)
> > > > > > > >
> > > > > > > > diff --git
> > > > > > > > a/drivers/gpu/drm/verisilicon/vs_primary_plane.c
> > > > > > > > b/drivers/gpu/drm/verisilicon/vs_primary_plane.c
> > > > > > > > index 1f2be41ae496c..8d58682d88ef8 100644
> > > > > > > > --- a/drivers/gpu/drm/verisilicon/vs_primary_plane.c
> > > > > > > > +++ b/drivers/gpu/drm/verisilicon/vs_primary_plane.c
> > > > > > > > @@ -7,6 +7,7 @@
> > > > > > > >      
> > > > > > > >      #include <drm/drm_atomic.h>
> > > > > > > >      #include <drm/drm_atomic_helper.h>
> > > > > > > > +#include <drm/drm_blend.h>
> > > > > > > >      #include <drm/drm_crtc.h>
> > > > > > > >      #include <drm/drm_fourcc.h>
> > > > > > > >      #include <drm/drm_framebuffer.h>
> > > > > > > > @@ -179,5 +180,7 @@ struct drm_plane
> > > > > > > > *vs_primary_plane_init(struct
> > > > > > > > drm_device *drm_dev, struct vs_dc
> > > > > > > >      
> > > > > > > >      	drm_plane_helper_add(plane,
> > > > > > > > &vs_primary_plane_helper_funcs);
> > > > > > > >      
> > > > > > > > +	drm_plane_create_blend_mode_property(plane,
> > > > > > > > +					
> > > > > > > > BIT(DRM_MODE_BLEND_PIXEL_NONE));
> > > > > > > >      	return plane;
> > > > > > > >      }

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)