Re: [PATCH v2 net] octeontx2-af: fix PF/CGX debugfs PCI bus lookup

From: Simon Horman

Date: Thu Sep 10 2026 - 05:42:52 EST


On Thu, Sep 10, 2026 at 08:32:27AM +0530, Ratheesh Kannoth wrote:
> On 2026-09-10 at 08:23:09, netdev-bot+sashiko@xxxxxxxxxx (netdev-bot+sashiko@xxxxxxxxxx) wrote:
> > Thank you for your contribution! Sashiko AI review found 2 potential
> > issue(s) to consider:
> >
> > Critical: 0 · High: 1 (1) · Medium: 0 (1) · Low: 1
> >
> > - [High] Incomplete fix: the identical PF->PCI-device lookup in the
> > sibling CGX debugfs file is left broken.
> Concern is about a different function, which needs a fix of "domain" field.
> Will address in seperate patch.
>
> > - [Low] The recorded commit message describes only the bus-number change
> > ('It assumed PF0 always sits on PCI bus 1 and derived other PF bus…
> >
> > Pre-existing issues:
> > - [High] get_cpt_pf_num() (rvu_cpt.c:387-407) derives the RVU PF number
> > from the PCI bus number using the assumption this patch declares…
> > - [Medium] The inverse bus->PF translation in rvu_sdp_init() still
> > hardcodes base bus 1 and is consumed from inside the function this…
> Will take these up in seperate seperate patches

Thanks, this approach seems reasonable to me.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>

...