Re: [PATCH RESEND] selftests/filesystems: include fcntl.h in fclog
From: Arthur Cassegrain
Date: Thu Sep 10 2026 - 05:46:58 EST
> fclog.c uses open(), O_RDONLY, O_CLOEXEC and AT_FDCWD, but it does
> not include <fcntl.h>, where they are declared or defined.
>
> This was hidden while <sys/mount.h> pulled in <fcntl.h> indirectly.
> glibc stopped providing that transitive include in [1], which exposes
> the missing direct dependency.
>
> Include <fcntl.h> explicitly so fclog.c builds with glibc 2.44
> development headers.
>
> [1] glibc -- change 419245719ccb ("include: isolate __O_CLOEXEC flag for
> sys/mount.h and fcntl.h")
> Link: https://sourceware.org/git/?p=glibc.git;a=commit;h=419245719ccb
>
> Fixes: df579e471111 ("selftests/filesystems: add basic fscontext log tests")
> Reported-by: NeilBrown <neilb@xxxxxxxxxxx>
> Closes: https://lore.kernel.org/all/178331747789.27465.4739600418387513587@xxxxxxxxxxxxxxxxxxxxx/
> Signed-off-by: Arthur Cassegrain <arthur.cassegrain@xxxxxxx>
> ---
Sorry, I just realized that this fix has already been merged:
https://lore.kernel.org/all/20260710171741.837308-1-jkoolstra@xxxxxxxxx/
Please ignore this resend.
Thanks,
Arthur