Re: [PATCH v4 3/4] ARM: dts: mediatek: mt8127: Add watchdog support

[AngeloGioacchino Del Regno]

On 9/9/26 21:38, Zakariya Hadrami via B4 Relay wrote:
> From: Zakariya Hadrami <zkh@xxxxxxxxxxx>
>
> Add watchdog node and disable it by default as it was not present
> initially.
>
> Signed-off-by: Zakariya Hadrami <zkh@xxxxxxxxxxx>
> ---
>   arch/arm/boot/dts/mediatek/mt8127.dtsi | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/mediatek/mt8127.dtsi b/arch/arm/boot/dts/mediatek/mt8127.dtsi
> index bd61ec7e70c0..3e23673e7a9e 100644
> --- a/arch/arm/boot/dts/mediatek/mt8127.dtsi
> +++ b/arch/arm/boot/dts/mediatek/mt8127.dtsi
> @@ -99,6 +99,13 @@ soc {
>   		compatible = "simple-bus";
>   		ranges;
>   
> +		watchdog: watchdog@10007000 {
> +			compatible = "mediatek,mt8127-wdt","mediatek,mt6589-wdt";

Missing space:

compatible = "mediatek,mt8127-wdt", "mediatek,mt6589-wdt";

After fixing,

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

P.S.: If you send a v5 between now and now (or next week too :-P) I can pick it
in this cycle.

Cheers,
Angelo

> +			reg = <0 0x10007000 0 0x100>;
> +			interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_LOW>;
> +			status = "disabled";
> +		};
> +
>   		timer: timer@10008000 {
>   			compatible = "mediatek,mt8127-timer",
>   					"mediatek,mt6577-timer";