Re: [patch v2] lib: test_vmstat: add synthetic benchmark for vm stats

[David Hildenbrand (Arm)]

On 8/22/26 01:52, David Rientjes wrote:
> On Fri, 7 Aug 2026, David Rientjes wrote:
> 
>> On Sun, 2 Aug 2026, David Rientjes wrote:
>>
>>> From: Christoph Lameter <cl@xxxxxxxxxx>
>>>
>>> Add a synthetic benchmark that can be used to measure performance of VM
>>> statistics.  This is used to analyze any improvements or regressions in
>>> functions that are frequently used in hot code paths.
>>>
>>> The test is run by inserting the module: modprobe test_vmstat
>>> The module insertion will always fail so that it is automatically
>>> unloaded; the results are in the kernel log.
>>>
>>> Signed-off-by: Christoph Lameter <cl@xxxxxxxxxx>
>>> Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx>
>>> ---
>>>  v2:
>>>   - added bash wrapper to ksft per David
>>>   - integrated into ksft
>>>   - added MAINTAINERS entry per David
>>>   - fixed alloc_page() error code per Usama
>>>
>>>  Adding single test for now to solicit feedback before updating the other
>>>  two.
>>>
>>
>> Any feedback for this one?  If this one looks good then I can also apply 
>> the same treatment for test_pagealloc and test_slab.
>>
> 
> Andrew, David, any thoughts on whether this one is acceptable for merge?  
> If this looks structually correct and is staged for inclusion, then I'll 
> do the same treatment to the other two proposed tests as well.

Please send new revisions next time not as reply to previous revisions, makes it
easier to miss them ;)

I still dislike placing them in lib/ but as discussed, we can handle that
separately (CCing Sarthak).

As replied to v1, is there any chance we could convert some of that to kunit?

-- 
Cheers,

David