Re: [PATCH net v9 01/14] afs: Fix lack of loop around sendmsg() to rxrpc

[David Howells]

David Laight <david.laight.linux@xxxxxxxxx> wrote:

> > +	do {
> > +		ret = rxrpc_kernel_send_data(call->net->socket, rxcall, &msg,
> > +					     msg_data_left(&msg),
> > +					     afs_notify_end_request_tx);
> > +		if (ret < 0)
> > +			goto error_do_abort;
> > +	} while (msg_data_left(&msg) > 0);
> 
> Is there any reason you didn't change rxrpc_kernel_send_data() instead?

My thought was to keep rxrpc_kernel_send_data() operating reasonably similarly
to sendmsg(), but I think you're right - that's a better way to do this since
I don't think there's a circumstance that I wouldn't then loop around it.

David