Re: [PATCH v5 4/6] drm/ssd130x: Replace positional ssd130x_spi_id[] initialization with C99

From: Javier Martinez Canillas

Date: Thu Sep 10 2026 - 07:18:57 EST


Amit Barzilai <amit.barzilai22@xxxxxxxxx> writes:

> ssd130x_spi_id[] is initialized with positional initializers, which
> easily create easy-to-miss bugs when changing the members of the target
> struct (struct spi_device_id in this example).
>
> Change this to C99 initializers to guarantee each member is initialized
> with the correct value.
>
> Signed-off-by: Amit Barzilai <amit.barzilai22@xxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat