Re: [PATCH 02/23] scripts/mksysmap: fix escape of '$' in the __pi_ pattern

[Lorenzo Stoakes (ARM)]

On Wed, Sep 09, 2026 at 09:47:18PM +0200, Nicolas Schier wrote:
> > Commit b18b047002b7 ("kbuild: change scripts/mksysmap into sed script")
> > converted scripts/mksysmap from a shell script to a sed script.
> >
> > However an error was made - escaping of '$' required \\ escaping in shell
> > but only \ in a sed script.
> >
> > This was mostly corrected in commit 7a6c355b55c0 ("scripts/mksysmap: Fix
> > escape chars '$'"), but this fix missed arm64 PIE namespace local symbols
> > like __pi_$x and __pi_$d which appear in System.mapand /proc/kallsyms:
> >
> > $ grep __pi_\\$ /proc/kallsyms | sort -u
> > 0000000000000000 d __pi_$d
> > 0000000000000000 t __pi_$x
> >
> > Fix the escaping properly.
> >
> > Fixes: b18b047002b7 ("kbuild: change scripts/mksysmap into sed script")
> >
> > No measurable change in build time.
> >
> > Assisted-by: LLM
> > Signed-off-by: Lorenzo Stoakes (ARM) <ljs@xxxxxxxxxx>
> >
> > diff --git a/scripts/mksysmap b/scripts/mksysmap
> > index 56a8b8bbdb37..856b26ba2ac0 100755
> > --- a/scripts/mksysmap
> > +++ b/scripts/mksysmap
> > @@ -35,7 +35,7 @@
> >  / __efistub_/d
> >
> >  # arm64 local symbols in PIE namespace
> > -/ __pi_\\$/d
> > +/ __pi_\$/d
> >  / __pi_\.L/d
> >
> >  # arm64 local symbols in non-VHE KVM namespace
>
> (Move 'Fixes:' to trailer block)

Yeah similar screw up. I think it was when perf times were appended
per-patch but then then ended up on the fix patches + I yanked them bit
didn't correct the tags, ugh!

>
> Reviewed-by: Nicolas Schier <nsc@xxxxxxxxxx>

Thanks! :)

>
> --
> Nicolas
>

--
Cheers, Lorenzo