Re: [PATCH v5 2/3] kselftest: mm: replace usage of /proc/self/smaps for check_huge_xxx() helper

[Yeoreum Yun]

On Thu, Sep 10, 2026 at 01:27:41PM +0200, David Hildenbrand (Arm) wrote:
> On 9/10/26 13:25, Yeoreum Yun wrote:
> >> On 9/10/26 12:54, Yeoreum Yun wrote:
> >>>
> >>> Agree. but there seems the case where discern whethr the mapping is
> >>> with regular file or shmem like tmpfs -- khugepaged test where using
> >>> __shmem_ops. So I think it would be better to keep this as-is.
> >>
> >> Let's not add or maintain unnecessary complexity.
> >>
> >> hmem_check_huge can really just become check_huge_file.
> >>
> >> Even file_check_huge can just be simplified.
> >>
> >> There must be a pretty good reason why we'd want to keep this.
> > 
> > Okay. then I'll change the check_huge_shmem() to check_huge_file()
> > with the separate patch.
> 
> You'll likely have to make both behave the same under the hood first to then
> remove check_huge_shmem().

Acked.

-- 
Sincerely,
Yeoreum Yun