Re: [PATCH net-next v1] net: phy: realtek: improve firmware write speed

From: Andrew Lunn

Date: Thu Sep 10 2026 - 08:35:11 EST


On Thu, Sep 10, 2026 at 10:49:26AM +0800, javen wrote:
> From: Javen Xu <javen_xu@xxxxxxxxxxxxxx>
>
> Firmware execution routine unconditionally uses phy_modify_mmd() for
> all OP_WRITE entries which introduces an unnecessary read transaction
> when updating an entire 16-bit register. So we optimize this by
> checking bitmask boundaries. Use phy_write_mmd() directly to speed up
> firmware loading process.

For optimisations, it is normal to include some benchmark numbers to
show how big a change it made. Is the added complexity worth the
change?

Andrew