Re: [PATCH v3] dmaengine: sprd: use clk_bulk API to fix clock imbalance

[Vinod Koul]

On Wed, 19 Aug 2026 05:35:18 +0000, Chaithanya Lagisetty wrote:
> sprd_dma_enable() enabled sdev->clk and then the optional ashb_clk. If
> enabling ashb_clk failed, sdev->clk was left enabled: both callers
> (probe and resume) treat a non-zero return as "nothing was enabled" and
> bail out, leaking sdev->clk.
> 
> Convert the driver to the clk_bulk API. clk_bulk_prepare_enable()
> enables all clocks and unwinds them on failure, and
> clk_bulk_disable_unprepare() disables them, which fixes the imbalance
> and simplifies the enable/disable paths. Both clocks are fetched with
> devm_clk_bulk_get_optional(); the optional ashb_eb clock simply becomes
> a NULL entry that the bulk helpers treat as a no-op, while the mandatory
> enable clock is still checked explicitly.
> 
> [...]

Applied, thanks!

[1/1] dmaengine: sprd: use clk_bulk API to fix clock imbalance
      commit: d09cd5e8bbc98969b5333015b45c525078ac0f6f

Best regards,
-- 
~Vinod