Re: [PATCH 10/12] mm/sparse: remove flags parameter from sparse_init_one_section()

[Lorenzo Stoakes (ARM)]

On Wed, Sep 09, 2026 at 03:33:03PM +0200, David Hildenbrand (Arm) wrote:
> Unused, let's remove it.

Might be worth saying because of the changes ;)

>
> Signed-off-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>

But this is a nice change, always good to remove params/code if possible... :)

Reviewed-by: Lorenzo Stoakes (ARM) <ljs@xxxxxxxxxx>


> ---
>  mm/sparse-vmemmap.c | 2 +-
>  mm/sparse.c         | 2 +-
>  mm/sparse.h         | 5 ++---
>  3 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c
> index 5aba058df6b67..25d3472972363 100644
> --- a/mm/sparse-vmemmap.c
> +++ b/mm/sparse-vmemmap.c
> @@ -894,7 +894,7 @@ int __meminit sparse_add_section(int nid, unsigned long start_pfn,
>  	/* Align memmap to section boundary in the subsection case */
>  	if (section_nr_to_pfn(section_nr) != start_pfn)
>  		memmap = pfn_to_page(section_nr_to_pfn(section_nr));
> -	sparse_init_one_section(ms, section_nr, memmap, ms->usage, 0);
> +	sparse_init_one_section(ms, section_nr, memmap, ms->usage);
>
>  	return 0;
>  }
> diff --git a/mm/sparse.c b/mm/sparse.c
> index 344acaaed94db..d2e7c21319e27 100644
> --- a/mm/sparse.c
> +++ b/mm/sparse.c
> @@ -245,7 +245,7 @@ static void __init sparse_metadata_init_nid(int nid,
>  		memmap_boot_pages_add(section_nr_vmemmap_pages(pfn, PAGES_PER_SECTION,
>  							       NULL, NULL));
>  		sparse_init_one_section(__nr_to_section(section_nr), section_nr,
> -					mem_map, usage, 0);
> +					mem_map, usage);
>  		usage = (void *)usage + mem_section_usage_size();
>  	}
>  }
> diff --git a/mm/sparse.h b/mm/sparse.h
> index 03351f2467e34..f45dd280db6ff 100644
> --- a/mm/sparse.h
> +++ b/mm/sparse.h
> @@ -91,7 +91,7 @@ int sparse_index_init(unsigned long section_nr, int nid);
>
>  static inline void sparse_init_one_section(struct mem_section *ms,
>  		unsigned long section_nr, struct page *mem_map,
> -		struct mem_section_usage *usage, unsigned long flags)
> +		struct mem_section_usage *usage)
>  {
>  	unsigned long coded_mem_map;
>
> @@ -109,8 +109,7 @@ static inline void sparse_init_one_section(struct mem_section *ms,
>  	VM_WARN_ON_ONCE(coded_mem_map & ~SECTION_MAP_MASK);
>
>  	ms->section_mem_map &= ~SECTION_MAP_MASK;
> -	ms->section_mem_map |= coded_mem_map;
> -	ms->section_mem_map |= flags | SECTION_HAS_MEM_MAP;
> +	ms->section_mem_map |= coded_mem_map | SECTION_HAS_MEM_MAP;
>  	ms->usage = usage;
>  }
>
>
> --
> 2.43.0
>

--
Cheers, Lorenzo