Re: [PATCH v1 3/7] arm64: dts: freescale: Add Lino iMX93

[Francesco Dolcini]

Hello Frank,
thanks for the review.

On Thu, Sep 10, 2026 at 11:04:26AM -0500, Frank Li wrote:
> On Thu, Sep 10, 2026 at 12:16:09PM +0200, Francesco Dolcini wrote:
> > From: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> >
> > Add support for the Lino iMX93 SoM, its Verdin adapter and development
> > carrier board.
> >
> > The SoM is available in two variants, with i.MX91 or i.MX93 SoC, using
> > the same PCB (the two chips are pin to pin compatible), to avoid
> > duplication create a common dtsi to share commonalities.
> >
> ...
> > +};
> > +
> > +&gpio1 {
> > +	gpio-line-names =
> > +		"LINO_P18",
> > +		"LINO_P16",
> > +		"PMIC_I2C_SCL",
> > +		"PMIC_I2C_SDA",
> > +		"",
> > +		"",
> > +		"",
> > +		"",
> > +		"",
> > +		"",
> > +		"LINO_P65", /* 10 */
> > +		"LINO_S18",
> > +		"LINO_S24",
> > +		"LINO_S20",
> > +		"LINO_S22",
> > +		"";
> 
> Can you wrap, 4 pin pre one line to reduce LOC.

I would prefer no.

This way is very easy to jump to the right line and see what's there
(e.g. I can jump 14 lines down with 14j in vim and I see immediately
which gpio is that).

To my personal taste is also more read-able and consistent with the
other Toradex DT files.

Is there any other reason to ask for this change? Any style guideline on
this topic?

Francesco