Re: [PATCH 1/2] ASoC: mediatek: common: Propagate control and DAPM errors
From: Mark Brown
Date: Thu Sep 10 2026 - 13:33:26 EST
On Thu, Sep 10, 2026 at 06:43:37PM +0700, phucduc.bui@xxxxxxxxx wrote:
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> mtk_afe_add_sub_dai_control() currently ignores errors from
> ASoC control and DAPM setup functions.
>
> Propagate these errors to the caller.
mt8365-afe-pcm.c has:
{"HW_GAIN1_IN_CH1", "CONNSYS_I2S_CH1", "Hostless FM DL"},
missing a Switch from the control. I suspect there's other errors; this
really needs to be tested before it can be applied. Given the general
quality of the driver here and the lack of anything constructive we're
doing with the errors changes like this have high risk and low reward
unless we're actually running the code.
Attachment:
signature.asc
Description: PGP signature