Re: [PATCH 4/5] workqueue: build percpu pwqs through the attrs path

From: Tejun Heo

Date: Thu Sep 10 2026 - 14:17:04 EST


Hello,

On Thu, Sep 10, 2026 at 03:13:15AM -0700, Breno Leitao wrote:
> Sure. Would a if() in put_pwq() cause harm? This is what I came up with.
> Any chance it would be acceptable?

A failed system workqueue allocation hits BUG_ON() in workqueue_init_early()
anyway. Please use BUG_ON(!pwq_release_worker) with a comment explaining why
the failure is unrecoverable.

Thanks.

--
tejun