Re: [PATCH] ice: fix double dereference in TP_printk problems in ice_{rx,tx}_dim_template
From: Tony Nguyen
Date: Thu Sep 10 2026 - 17:12:21 EST
On 9/7/2026 9:48 AM, Stefan Metzmacher wrote:
ice_tx_dim_work and ice_rx_dim_work generate the
following: "has double dereference in TP_printk" errors:
REC->q_vector->tx.tx_ring->q_index
REC->dim->state
REC->dim->profile_ix
REC->dim->tune_state
REC->dim->steps_right
REC->dim->steps_left
REC->dim->tired
Thanks for the patch Stefan but Jakub has already submitted a patch [1] that's en route to fix this.
Thanks,
Tony
[1] https://lore.kernel.org/intel-wired-lan/aqFp78nsYmT8gRDO@xxxxxxxxx/T/#ma04a6a8301063209e8eae383e31293953f4eba46
And the first one hits a WARN_ONCE()...
Fixes: 3089cf6d3caa ("ice: add tracepoints")
Cc: Tony Nguyen <anthony.l.nguyen@xxxxxxxxx>
Cc: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>
Cc: Andrew Lunn <andrew+netdev@xxxxxxx>
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
Cc: Paolo Abeni <pabeni@xxxxxxxxxx>
Cc: intel-wired-lan@xxxxxxxxxxxxxxxx
Cc: netdev@xxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Signed-off-by: Stefan Metzmacher <metze@xxxxxxxxx>