Re: [PATCH v4 2/2] gpio: realtek-otto: add pinctrl support
From: Michael Zavertkin
Date: Thu Sep 10 2026 - 17:32:30 EST
On Thu, Sep 10, 2026 at 02:11:51AM -0700, Bartosz Golaszewski wrote:
> On Wed, 2 Sep 2026 15:02:01 +0200, Michael Zavertkin
> <misha.zavertkin@xxxxxxx> said:
> > On Wed, Sep 02, 2026 at 11:27:50AM +0200, Bartosz Golaszewski wrote:
> >> On Thu, Aug 27, 2026 at 4:29 PM Michael Zavertkin
> >> <misha.zavertkin@xxxxxxx> wrote:
> >> >
> >> > RTL9607C relies on pinctrl to mux SoC pins. Use pinctrl to request pins
> >> > for GPIO.
> >> > pinctrl driver for other SoCs might be implemented later.
> >> >
> >>
> >> So for now shouldn't you make it conditional on the compatible for
> >> this one model?
> >>
> >> Bart
> >
> > It might, but enabling it for all will spare time if/when pin
> > controllers for other SoCs will be implemented. And it doesn't change
> > anything if pinctrl not enabled/provided for them.
> >
> >
>
> Sashiko claims otherwise[1] so I had a look and it seems to me that it's
> correct saying we'll defer indefinitely for GPIO chips not backed by a pin
> controller.
>
> Bart
>
> [1] https://sashiko.dev/#/patchset/cover.1787830440.git.misha.zavertkin%40mail.ru
Already addressed: https://patch.msgid.link/20260820-fix-gpio-mmio-pinctrl-v1-1-62c2d7dd4903@xxxxxxxxxx
Tried it myself, without that patch infinite defers happens if no
pinctrl provided. After patch applied probe loop doesn't happen.