RE: [PATCH 3/5] arm64: dts: fsd: Move idle states out of CPUs node

[Alim Akhtar]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> Sent: Wednesday, September 9, 2026 7:48 PM
> To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; linux-fsd@xxxxxxxxx;
> Krzysztof Kozlowski <krzk@xxxxxxxxxx>; Peter Griffin
> <peter.griffin@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Conor Dooley
> <conor+dt@xxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-
> soc@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> Subject: [PATCH 3/5] arm64: dts: fsd: Move idle states out of CPUs node
> 
> Idle states are not really part of CPUs, as often they have domain idle states,
> so move them level up to fix to fix dt-check-style warning:
> 
>   fsd.dtsi:300: [child-name-order] child node 'idle-states' out of name order
> 
> Also, re-order properties to silence:
> 
>   fsd.dtsi:305: [property-order] property 'compatible' out of canonical order
> (should sort before 'idle-state-name')
>   fsd.dtsi:308: [property-order] property 'entry-latency-us' out of canonical
> order (should sort before 'arm,psci-suspend-param')
> 
> Signed-off-by: Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> ---
Probably this need to be done for many other SoCs and platforms

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>


>  arch/arm64/boot/dts/tesla/fsd.dtsi | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi
> b/arch/arm64/boot/dts/tesla/fsd.dtsi
> index d076ea634f4e..acbe93756a76 100644
> --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> @@ -296,19 +296,19 @@ cpucl_l2: l2-cache0 {
>  			cache-line-size = <64>;
>  			cache-sets = <4096>;
>  		};
> +	};
> 
> -		idle-states {
> -			entry-method = "psci";
> +	idle-states {
> +		entry-method = "psci";
> 
> -			cpu_sleep: cpu-sleep {
> -				idle-state-name = "c2";
> -				compatible = "arm,idle-state";
> -				local-timer-stop;
> -				arm,psci-suspend-param = <0x0010000>;
> -				entry-latency-us = <30>;
> -				exit-latency-us = <75>;
> -				min-residency-us = <300>;
> -			};
> +		cpu_sleep: cpu-sleep {
> +			compatible = "arm,idle-state";
> +			idle-state-name = "c2";
> +			local-timer-stop;
> +			entry-latency-us = <30>;
> +			exit-latency-us = <75>;
> +			min-residency-us = <300>;
> +			arm,psci-suspend-param = <0x0010000>;
>  		};
>  	};
> 
> 
> --
> 2.53.0