RE: [PATCH 4/5] arm64: dts: fsd: Re-order nodes to match coding style

[Alim Akhtar]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> Sent: Wednesday, September 9, 2026 7:48 PM
> To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; linux-fsd@xxxxxxxxx;
> Krzysztof Kozlowski <krzk@xxxxxxxxxx>; Peter Griffin
> <peter.griffin@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Conor Dooley
> <conor+dt@xxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-
> soc@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> Subject: [PATCH 4/5] arm64: dts: fsd: Re-order nodes to match coding style
> 
> Re-order several top-level and MMIO nodes to match coding style - ordering
> by name or by unit address, as pointed out by dt-check-style,
> e.g.:
> 
>   fsd.dtsi:981: [child-address-order] child node @10040000 out of address
> order
>   fsd.dtsi:315: [child-name-order] child node 'arm-pmu' out of name order
>   fsd.dtsi:348: [child-name-order] child node 'clock' out of name order
> 
> While moving chunks of code, also re-order a few properties (I2S, SPI and
> CAN nodes) to fix:
> 
>   fsd.dtsi:661: [property-order] property 'clocks' out of canonical order
> (should sort before 'samsung,syscon-phandle')
>   fsd.dtsi:936: [property-order] property 'pinctrl-names' must be placed after
> 'pinctrl-0'
>   fsd.dtsi:936: [property-order] property 'pinctrl-names' out of canonical
> order (should sort before 'samsung,spi-src-clk')
> 
> Moving several nodes already creates unreviewable commit, thus reshuffling
> the properties allows to skip changing the same line twice without loss of
> readability.
> 
> Signed-off-by: Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>