Re: [PATCH v2 2/2] clk: qcom: Add support for the camera clock controller (CAMCC) on Hawi

[Taniya Das]

On 9/9/2026 11:31 AM, Vivek Aknurwar wrote:
> +static struct gdsc cam_cc_titan_top_cx_gdsc = {
> +	.gdscr = 0x21388,
> +	.en_rest_wait_val = 0x2,
> +	.en_few_wait_val = 0x2,
> +	.clk_dis_wait_val = 0xf,
> +	.pd = {
> +		.name = "cam_cc_titan_top_cx_gdsc",
> +	},
> +	.pwrsts = PWRSTS_OFF_ON,
> +	.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
> +};
> +

I think we need to add, similar to downstream requirements.
Please check 'drivers/clk/qcom/camcc-milos.c' for example.

        .needs_icc = true,
        .icc_path_index = DT_ICC_TOP_GDSC,

> +static struct gdsc cam_cc_titan_top_gdsc = {
> +	.gdscr = 0x21330,
> +	.en_rest_wait_val = 0x2,
> +	.en_few_wait_val = 0x2,
> +	.clk_dis_wait_val = 0xf,
> +	.pd = {
> +		.name = "cam_cc_titan_top_gdsc",
> +	},
> +	.pwrsts = PWRSTS_OFF_ON,
> +	.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
> +	.parent = &cam_cc_titan_top_cx_gdsc.pd,
> +};

Here too.

-- 
Thanks,
Taniya Das