Re: [PATCH v4 4/9] phy: qualcomm: qmp-combo: Add hardware-specific DP PHY config fields

[Manivannan Sadhasivam]

On Tue, Sep 08, 2026 at 07:30:57PM +0530, Nabige Aala wrote:
> From: Ritesh Kumar <ritesh.kumar@xxxxxxxxxxxxxxxx>
> 
> Add dp_aux_cfg2, dp_phy_cfg1, and dp_mode_ignore_reverse fields to
> qmp_phy_cfg to allow hardware-specific DP PHY register values to be
> specified per-platform rather than hardcoded in the configure functions.
> 
> Define named constants QSERDES_DP_PHY_AUX_CFG2_V456/V8 and
> QSERDES_DP_PHY_CFG1_V456/V8 for better readability and maintainability.
> 
> Populate the new fields in all existing DP PHY cfg structures:
> - V456-based platforms (sar2130p, sc8180x, sc8280xp, x1e80100, sm8250,
>   sm8350, sm8475, sm8550, sm8650, sm8750) use V456 constants
> - Glymur (V8) uses V8 constants and sets dp_mode_ignore_reverse = true
> 
> Update qmp_combo_configure_dp_mode() to honor dp_mode_ignore_reverse,
> so Glymur can bypass TypeC orientation-based lane reversal.
> 

I believe this dp_mode_ignore_reverse should be in a separate patch with
relevant fixes tag.

- Mani

-- 
மணிவண்ணன் சதாசிவம்