Re: [PATCH 1/2] regulator: dt-bindings: Add MPS MPQ4210

[Krzysztof Kozlowski]

On Thu, Sep 10, 2026 at 08:51:41AM +0000, Tapio Reijonen wrote:
> The MPQ4210 is a 40V synchronous four-switch buck-boost controller with
> an I2C interface. Its output voltage is programmed through an 11-bit
> feedback reference DAC covering 0 to 2.047V in 1mV steps, and is then
> scaled by an external feedback resistor divider, so the divider ratio
> has to be described in the device tree for the driver to translate
> reference voltages into output voltages.
> 
> The divider is given in ohms rather than the kilo ohms used by
> mps,mp886x.yaml because the bottom resistor is not necessarily a whole
> number of kilo ohms.
> 
> The same divider scales the reference ramp rate, so unlike the other
> bindings that scale by a feedback divider there is no portable value a
> board can copy into regulator-ramp-delay. Describe how the selectable
> rates are derived from the four reference slew rates, and show the
> calculation in the example.
> 
> Signed-off-by: Tapio Reijonen <tapio.reijonen@xxxxxxxxxxx>
> ---
>  .../devicetree/bindings/regulator/mps,mpq4210.yaml | 69 ++++++++++++++++++++++
>  MAINTAINERS                                        |  5 ++
>  2 files changed, 74 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml b/Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..e9e7a87e7533d0948927a459e9af711d1e07e572
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/mps,mpq4210.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Monolithic Power Systems MPQ4210 buck-boost regulator
> +
> +maintainers:
> +  - Tapio Reijonen <tapio.reijonen@xxxxxxxxxxx>
> +
> +description:
> +  The MPQ4210 is a synchronous four-switch buck-boost controller with an I2C
> +  interface. The output voltage is programmed through an 11-bit feedback
> +  reference DAC and scaled by an external feedback resistor divider.
> +
> +  The controller ramps the feedback reference at 38, 50, 75 or 150 mV/ms.
> +  The divider scales the ramp rate along with the voltage, so the output
> +  ramp rates that regulator-ramp-delay can select are those values
> +  multiplied by (R1 + R2) / R2.
> +
> +allOf:
> +  - $ref: regulator.yaml#
> +
> +properties:
> +  compatible:
> +    const: mps,mpq4210
> +
> +  reg:
> +    maxItems: 1
> +
> +  enable-gpios:
> +    description: GPIO connected to the EN pin. If absent, EN is assumed to
> +      be permanently asserted.
> +    maxItems: 1
> +
> +  mps,fb-voltage-divider:
> +    description: An array of two integers containing the resistor values R1
> +      and R2 of the output feedback voltage divider in ohms.

Nope, use common property suffix - ohms.

If this was applied, please send a fixup now.

Best regards,
Krzysztof