Re: [PATCH 1/4] mm/pagewalk: delete the unused member

[Lorenzo Stoakes (ARM)]

Please fix your cc'ing.

Cc- everybody on every mail.

You cc me only on this (1/4) and 3/4 but then don't on an mm/rmap.c change in
2/4 when I co-maintain rmap.

And 4/4 is about use of VMA locks which I also co-maintain :)

Just cc- everybody on everything...

On Fri, Sep 11, 2026 at 04:07:25PM +0800, xu.xin16@xxxxxxxxxx wrote:
> From: Xu Xin (ZTE) <xu.xin@xxxxxxxxx>
>
> The member vma has never been used, we should delete it

This is very sparse. Can you back this by talking about commits and how the VMA
is actually used? Have you audited it to make sure?

>
> Fixes: aa39ca6940f1a ("mm/pagewalk: introduce folio_walk_start() + folio_walk_end()")

I don't see why a fixes tag is necessary here. The struct folio_walk value is
kept on the stack so what exactly is the point of treating it like a fix?

> Signed-off-by: Xu Xin (ZTE) <xu.xin@xxxxxxxxx>

AFAICT this isn't currently used but I think I need to hear a stronger argument
in the commit msg before I go looking myself...!

> ---
>  include/linux/pagewalk.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/pagewalk.h b/include/linux/pagewalk.h
> index b41d7265c01b..1c397be0d092 100644
> --- a/include/linux/pagewalk.h
> +++ b/include/linux/pagewalk.h
> @@ -183,7 +183,6 @@ struct folio_walk {
>  		pmd_t pmd;
>  	};
>  	/* private */
> -	struct vm_area_struct *vma;
>  	spinlock_t *ptl;
>  };
>
> --
> 2.25.1

--
Cheers, Lorenzo