Re: [PATCH 1/3] dt-bindings: media: i2c: dw9800: Redocument DW9800K

[Krzysztof Kozlowski]

On Thu, Sep 10, 2026 at 04:54:16PM +0200, Griffin Kroah-Hartman wrote:
> The DW9800K's properties are too different to justify sharing the same
> bindings file as the dw9719, Create a separate bindings documentation

Say here something useful which not immediately visible from the diff -
which properties are different?

> for the Dongwoon Anatech DW9800K with it's updated properties.
> 
> Signed-off-by: Griffin Kroah-Hartman <griffin.kroah@xxxxxxxxxxxxx>
> ---
>  .../bindings/media/i2c/dongwoon,dw9719.yaml        |  1 -
>  .../bindings/media/i2c/dongwoon,dw9800k.yaml       | 91 ++++++++++++++++++++++
>  2 files changed, 91 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9719.yaml b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9719.yaml
> index 8e8d62436e0d..38db0764c0f7 100644
> --- a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9719.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9719.yaml
> @@ -21,7 +21,6 @@ properties:
>        - dongwoon,dw9718s
>        - dongwoon,dw9719
>        - dongwoon,dw9761
> -      - dongwoon,dw9800k
>  
>    reg:
>      maxItems: 1
> diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9800k.yaml b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9800k.yaml
> new file mode 100644
> index 000000000000..046c0a88bcef
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9800k.yaml
> @@ -0,0 +1,91 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/dongwoon,dw9800k.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Dongwoon Anatech DW9800K Bi-Direction Voice Coil Motor (Bi-VCM) Controller
> +
> +maintainers:
> +  - Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
> +  - Griffin Kroah-Hartman <griffin.kroah@xxxxxxxxxxxxx>
> +
> +description:
> +  The Dongwoon DW9800K is a single 10-bit digital-to-analog converter with
> +  +-130 mA output current sink capability, designed for linear control of
> +  bi-directional voice coil motors (Bi-VCM) in camera lenses. This chip
> +  provides a Smart Actuator Control (SAC) mode intended for minimizing
> +  mechanical vibration.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - dongwoon,dw9800k
> +
> +  reg:
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description: VDD power supply, can range from 2.3V to 4.8V
> +
> +  dongwoon,sac-mode:
> +    description: >
> +      Slew Rate Control mode to use: direct, LSC (Linear Slope Control) or
> +      SAC2-SAC5 (Smart Actuator Control).
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum:
> +      - 0 # Direct mode
> +      - 1 # LSC mode
> +      - 2 # SAC2 mode (operation time# 0.48 x Tvib)
> +      - 3 # SAC3 mode (operation time# 0.72 x Tvib)
> +      - 4 # SAC4 mode (operation time# 1.20 x Tvib)
> +      - 5 # SAC5 mode (operation time# 1.64 x Tvib)
> +    default: 3
> +
> +  dongwoon,clock-presc:

Why this cannot be named the same? Commit msg should answer such
questions.

> +    description:
> +      Indication of VCM internal clock dividing rate select, as one multiple
> +      factor to calculate VCM ring periodic time Tvib.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum:
> +      - 0 #  Dividing Rate -  2
> +      - 1 #  Dividing Rate -  1
> +      - 2 #  Dividing Rate -  1/2
> +      - 3 #  Dividing Rate -  1/4
> +      - 4 #  Dividing Rate -  8
> +      - 5 #  Dividing Rate -  4
> +    default: 1
> +
> +  dongwoon,timing-control:

So it seems you have only one different property, quite a difference
comparing to bold statement in commit msg?

Best regards,
Krzysztof