Re: [PATCH v3 2/3] media: i2c: Add Sony IMX681 sensor driver

From: Sergey Lebedev

Date: Fri Sep 11 2026 - 05:46:24 EST


All three taken, and this answers your note on 1/3 as well. One of them is
wider than you flagged.

- MAINTAINERS `T:` dropped. You are right that we have no commit rights there,
and the convention agrees: 14 of 96 drivers/media/i2c entries carry a `T:`
line and 82 do not.

- `dev_err` then `return ret` after devm_cci_regmap_init_i2c() becomes
dev_err_probe(). The same shape is in twelve other probe-path sites, so v4
converts all thirteen rather than only the one quoted. The seven in
imx681_start_streaming(), imx681_stop_streaming() and imx681_power_on() stay
as they are - power_on() is reached from runtime-PM resume as well as from
probe, so it is not a probe path.

- The clk_get_rate() dev_dbg goes.

Recorded for v4: your Reviewed-by, on 1/3 where you gave it. German supplied a
full name after your note - German Pablo Lindo - and his Tested-by goes on 2/3
and nowhere else, since as you say it does not apply to a binding.

v4 is not sent today, and the reason is the other thing you asked for: André
should ack the binding, and he is away until 28 September. Rather than respin
twice I will hold briefly for that and for any comment on 2/3 and 3/3 on their
merits, then send once.

Sergey