Re: [PATCH v7 09/12] crypto: qce - remove the BROKEN label

[Bartosz Golaszewski]

On Thu, 10 Sep 2026 16:31:40 +0200, Eric Biggers <ebiggers@xxxxxxxxxx> said:
> On Thu, Sep 10, 2026 at 03:00:50PM +0200, Bartosz Golaszewski wrote:
>> All self-tests now pass.
>
> Have the other bugs that were reported been fixed?  For example:
> https://lore.kernel.org/linux-crypto/20260723202704.GB110634@quark/
> https://lore.kernel.org/linux-crypto/20260723183438.GB93534@quark/
> https://lore.kernel.org/linux-crypto/20260723205342.GC110634@quark/
>

I will get to these too. For now, the series allows the self-tests to pass,
I assume it it's enough to not keep the BROKEN label.

>>  	help
>>  	  This driver supports Qualcomm crypto engine accelerator
>
> As this patch would make the kconfig option visible again and would
> result in everyone running "make oldconfig" being asked about it, it

I don't mind changing the symbol if you prefer it to avoid any accidental
`make oldconfig` carry-overs.

> needs to be fixed to accurately document why anyone would want to enable
> this option.  As you've stated, it's actually just for "testing".  The
> false claim that it's an "accelerator" also needs to go.
>

"Offloader" for lack of a better word?

Thanks,
Bart