Re: [PATCH v2 net-next] net: phy: mediatek: support MT7530 PHYs on EN71221 MCM

[Andrew Lunn]

> +	/* Clause 22 local data. */
> +	ret = phy_write(phydev, MII_CTRL1000, 0x1e00);

Didn't i ask for 0x1e00 to be replaced with standard macros?

> +	/* Vendor profile disables 100/1000BASE-T EEE advertisement. */
> +	ret = phy_write_mmd(phydev, MDIO_MMD_AN, 0x003c, 0x0000);
> +	if (ret < 0)
> +		return ret;

And didn't i ask if EEE is broken? We have infrastructure for that,
please use it.

Also, please start a new thread for every version of a patch
series. The CI tools don't always pick up replies to previous patch
versions, it thinks it is just ongoing discussion.

    Andrew

---
pw-bot: cr