Re: [PATCH net-next 1/7] net: dsa: motorcomm: Split xMII and SERDES port masks

[David Yang]

On Fri, Sep 11, 2026 at 7:46 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> On Fri, Sep 11, 2026 at 05:37:45AM +0800, David Yang wrote:
> > On Fri, Sep 11, 2026 at 4:59 AM Andrew Lunn <andrew@xxxxxxx> wrote:
> > >
> > > >  #define YT921X_PORT_MASK_INTn(port)  BIT(port)
> > > >  #define YT921X_PORT_MASK_INT0_n(n)   GENMASK((n) - 1, 0)
> > > >  #define YT921X_PORT_MASK_EXT0                BIT(8)
> > >
> > > I'm i right in says YT921X_PORT_MASK_EXT0 refers to port 8, because of
> > > BIT(8)? And YT921X_PORT_MASK_EXT1 BIT(9) means port 9?
> > >
> > >         Andrew
> >
> > Yes.
>
> Can we give these better names then, YT921X_PORT_MASK_EXT8, or
> YT921X_PORT_8_MASK_EXT.
>
>         Andrew

These indexes are used in the vendor reference.

Or maybe just BIT(8)? Since they are not used anywhere else and kind
of leftovers.