[PATCH] media: rkisp1: Fix Bayer demosaicing bypass

[Jacopo Mondi]

The RKISP1_CIF_ISP_DEMOSAIC_BYPASS bit, when set, bypasses the
demosaicing block on the RkISP1 ISP.

The current implementation however clears the bit when demosaicing
have to be bypassed and sets it when demosaicing has to be enabled,
effectively inverting the bypass bit handling logic.

Fix this by setting the bypass bit when disabling the demosaicing block,
and by clearing it instead when demosaicing has to be performed.

The issue never manifested itself as libcamera hasn't an algorithm
to control Bayer demosaicing bypass yet.

Fixes: 6c53a7b68c5d ("media: rkisp1: Implement extensible params support")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx>
---
media: rkisp1: Fix demosaicing bypass
---
 drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
index 042b759eba62..496381962f1b 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
@@ -1854,8 +1854,8 @@ rkisp1_ext_params_bdm(struct rkisp1_params *params,
 	const struct rkisp1_ext_params_bdm_config *bdm = &block->bdm;
 
 	if (bdm->header.flags & RKISP1_EXT_PARAMS_FL_BLOCK_DISABLE) {
-		rkisp1_param_clear_bits(params, RKISP1_CIF_ISP_DEMOSAIC,
-					RKISP1_CIF_ISP_DEMOSAIC_BYPASS);
+		rkisp1_param_set_bits(params, RKISP1_CIF_ISP_DEMOSAIC,
+				      RKISP1_CIF_ISP_DEMOSAIC_BYPASS);
 		return;
 	}
 
@@ -1863,8 +1863,8 @@ rkisp1_ext_params_bdm(struct rkisp1_params *params,
 
 	if ((bdm->header.flags & RKISP1_EXT_PARAMS_FL_BLOCK_ENABLE) &&
 	    !(params->enabled_blocks & BIT(bdm->header.type)))
-		rkisp1_param_set_bits(params, RKISP1_CIF_ISP_DEMOSAIC,
-				      RKISP1_CIF_ISP_DEMOSAIC_BYPASS);
+		rkisp1_param_clear_bits(params, RKISP1_CIF_ISP_DEMOSAIC,
+					RKISP1_CIF_ISP_DEMOSAIC_BYPASS);
 }
 
 static void

---
base-commit: 27953c044974baf7e24dee3e9342fe0103dea80c
change-id: 20260911-imx8mp-demosaicing-bypass-bb284d9cca60

Best regards,
--  
Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx>