Re: [PATCH] HID: apple-touchbar: avoid nested runtime PM in PM callbacks

From: Jiri Kosina

Date: Fri Sep 11 2026 - 10:13:28 EST


On Mon, 10 Aug 2026, Andre Eikmeyer wrote:

> Hello everyone,
>
> Runtime suspend of the Touch Bar display stalls because its HID suspend
> callback requests a runtime PM resume while already running as part of the
> same USB PM transition. The nested request waits for the transition that
> invoked the callback to finish.
>
> The matching resume callback has the same problem. It can stall after the
> virtual host controller has successfully resumed the port.
>
> The mode update is therefore split into an active-device helper and a
> runtime-PM-managed wrapper. Both PM callbacks call the active-device
> helper and no longer acquire a nested runtime PM reference.
>
> We maintain the apple-bce/t2bce virtual host controller used on these
> systems. Although that module is not yet upstream, its runtime PM path has
> already been adjusted so the complete suspend and resume cycle works with
> this change.
>
> Thanks for your time and work.
>
> Signed-off-by: Andre Eikmeyer <dev@deq.rocks>

I have removed the "Hello" and "thanks" from the changelog :) and applied.

Thanks, and sorry for the delay.

--
Jiri Kosina
SUSE Labs