Re: [PATCH v3 1/9] dmaengine: Support bus widths of 32 bytes and above

[Andy Shevchenko]

On Fri, Sep 11, 2026 at 04:14:20PM +0100, Nuno Sá wrote:
> On Mon, Aug 31, 2026 at 04:56:18PM +0100, Nuno Sá wrote:
> > On Mon, Aug 31, 2026 at 04:45:15PM +0300, Andy Shevchenko wrote:
> > > On Mon, Aug 31, 2026 at 12:46:38PM +0100, Nuno Sá wrote:

...

> > > > +/*
> > > > + * Basic types shared by the DMA engine interfaces.
> > > > + */
> > > > +#ifndef LINUX_DMA_ENGINE_TYPES_H
> > > > +#define LINUX_DMA_ENGINE_TYPES_H
> > > > +
> > > > +#include <linux/bitops.h>
> > > 
> > > Not yet? Perhaps next changes will use it, then they can add it.
> > 
> > Should be dropped!
> 
> In fact, I'll keep the above! DECLARE_BITMAP() needs BITS_TO_LONGS().

I'm not sure I follow.

The DECLARE_BITMAP() comes from types.h. It's the problem of types.h to include
bitops.h for BITS_TO_LONGS() if required.

> Yeah, not great...

-- 
With Best Regards,
Andy Shevchenko