Re: [PATCH v2] HID: asus: do not send keyboard init reports to touchpads

[Jiri Kosina]

On Tue, 18 Aug 2026, Panz Dev wrote:

> Commit 0919db9f3583 ("HID: asus: always fully initialize devices") added a
> loop during asus_probe() to send keyboard feature report initializations
> (asus_kbd_init) to all ASUS HID devices.
> 
> On ASUS laptops with I2C/HID touchpads (such as the ASUS E200HA), sending
> keyboard feature reports (FEATURE_KBD_REPORT_ID) to touchpad endpoints
> sends invalid feature requests to touchpad hardware, corrupting probe
> state and causing the touchpad to become unresponsive.
> 
> Wrap the asus_report_id_init loop in an `if (!drvdata->tp)` check so
> keyboard feature initialization only runs for actual keyboards.
> 
> Tested on ASUS E200HA (where touchpad functionality is fully restored)
> and ASUS VivoBook Flip 14 TP401MA (confirming zero regressions).
> 
> Fixes: 0919db9f3583 ("HID: asus: always fully initialize devices")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Panz Dev <panz.development@xxxxxxxxx>
> ---
> v2:
>  - Keep asus_start_multitouch() inside the HID_CLAIMED_INPUT check to avoid
>    any UAF risk if input registration fails (as pointed out by Denis Benato
>    and automated review).
>  - Focus the fix on skipping keyboard report initialization for touchpads.

Applied to hid.git#for-7.4/asus, thanks.

-- 
Jiri Kosina
SUSE Labs