Re: [PATCH] x86/tdx: Remove the early #VE handler
From: Edgecombe, Rick P
Date: Fri Sep 11 2026 - 13:52:04 EST
On Fri, 2026-09-11 at 17:07 +0100, Kiryl Shutsemau wrote:
> > Is BOOT_KBD something that you think could be hit from a TDX guest?
>
> It is the first fallback from default BOOT_ACPI failure. But it is just
> an example of port I/O I found.
>
> > > Could you check if the patch changes panic() behaviour in the window
> > > before idt_setup_early_traps()?
> >
> > Can you describe more what you are imagining? panic() doing early printk or
> > some other port io? Wondering if you have some more specific hunch.
>
> I don't see panic() triggering early printk, but I see potential path to
> other port I/O as pointed above.
>
> I have vague recollection that I tried to remove it before, but
> something stopped me.
Yea, the risk is that some other usage is relying on this, even though the
comment in the handler says "Intended only for earlyprintk".
When doing the initial TDX guest work, did you guys consider trying to use some
alternatives magic to redirect #VE causing things to the tdvmcall helpers? I
guess it doesn't help the early boot case.