Re: [PATCH 2/2] regulator: Add MPS MPQ4210 buck-boost regulator driver

From: Uwe Kleine-König

Date: Fri Sep 11 2026 - 14:48:41 EST


Hello,

On Thu, Sep 10, 2026 at 08:51:42AM +0000, Tapio Reijonen wrote:
> +#include <linux/i2c.h>
> [...]
> +#include <linux/mod_devicetable.h>

Please don't add new includes for <linux/mod_devicetable.h>, this header
is supposed to go away. For i2c_device_id and of_device_id you can rely
on <linux/i2c.h> to provide both. If you want to go full iwyu use
<linux/device-id/i2c.h> and <linux/device-id/of.h> respectively.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature